fix: create 2 kinds of constructor for instantiation and instantiation of inherited types#2936
Closed
HerrCai0907 wants to merge 1 commit intoAssemblyScript:mainfrom
Closed
fix: create 2 kinds of constructor for instantiation and instantiation of inherited types#2936HerrCai0907 wants to merge 1 commit intoAssemblyScript:mainfrom
HerrCai0907 wants to merge 1 commit intoAssemblyScript:mainfrom
Conversation
…n of inherited types
Member
Author
|
similar but more complex constructor in C++: https://discourse.llvm.org/t/why-two-variants-of-every-constructor-are-created-by-the-compiler/73255 |
Member
|
Uh, what's the difference between the raw constructor and the normal constructor? |
Member
Author
|
The raw constructor will not allocate memory, it is used for inherited class's constuctor. |
Member
|
I don't think I can say much besides that it looks really strange...is there a way to have the normal constructor just call the "raw" constructor, instead of creating two distinct types of constructors? |
Member
Author
|
It introduce more complexity when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create 2 kinds constructor can help binaryen to optimize code better. since binaryen cannot optimize conditional allocation in base class. It will be obvious for
~lib/object/Objectbecause it is the base class for all kinds of class.